i386/92493: make buildworld stops: /usr/src/lib/libc/rpc/getpublickey.c (i386/6.0 RELEASE)

[Aluminium Oxide <orac000@xxxxxxxxxxxxxxxxx>]

>Number:         92493
>Category:       i386
>Synopsis:       make buildworld stops: /usr/src/lib/libc/rpc/getpublickey.c (i386/6.0 RELEASE)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 29 08:10:03 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Aluminium Oxide
>Release:        i386 6.0 RELEASE + RELENG_6_0_0_RELEASE
>Organization:
Reality Engineering
>Environment:
FreeBSD h2o.UNIVERSE.ore 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov  3 09:36:13 UTC 2005     root@xxxxxxxxxxxxxxx:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
On a FreeBSD 6.0 RELEASE/i386 + cvsup 3 days ago make buildworld stops with the following error:
__________________________________________________________________________________

cc -O2 -fno-strict-aliasing -pipe -O3 -march=pentium3 -msse -mmmx -pipe -fforce-mem -fforce-addr -funroll-loops -fcse-follow-jumps -march=pentium3 -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include -I/usr/src/lib/libc/i386 -D__DBINTERFACE_PRIVATE -I/usr/src/lib/libc/../../contrib/gdtoa -DINET6 -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP -DHESIOD -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /usr/src/lib/libc/rpc/getpublickey.c
In file included from /usr/src/lib/libc/rpc/getpublickey.c:178:
/usr/src/lib/libc/rpc/getpublickey.c: In function `getpublickey':
/usr/src/lib/libc/rpc/getpublickey.c:70: warning: passing arg 1 of `__getpublickey_real' discards qualifiers from pointer target type
*** Error code 1

Stop in /usr/src/lib/libc.

CFLAGS+=-O3 -march=pentium3 -msse -mmmx -pipe -fforce-mem -fforce-addr -funroll-loops -fcse-follow-jumps

I posted this a couple of weeks ago but with the wrong diff format,

A diff for the code fix is below (2 files). Please review my code.

>How-To-Repeat:
make buildworld on the described system.
>Fix:
diff -u /usr/src/lib/libc/rpc/getpublickey.c.org /usr/src/lib/libc/rpc/getpublickey.c
--- getpublickey.c.org  Sun Jan 29 18:14:28 2006
+++ getpublickey.c      Sun Jan 29 18:14:45 2006
@@ -169,7 +169,7 @@
 }

 int getpublickey(netname, publickey)
-       const char *netname;
+       char *netname;
        char *publickey;
 {
        if (__getpublickey_LOCAL != NULL)







 diff -u /usr/src/include/rpc/auth.h.org /usr/src/include/rpc/auth.h
--- auth.h.org  Sun Jan 29 18:16:06 2006
+++ auth.h      Sun Jan 29 18:16:21 2006
@@ -298,7 +298,7 @@
  * Publickey routines.
  */
 __BEGIN_DECLS
-extern int getpublickey (const char *, char *);
+extern int getpublickey (char *, char *);
 extern int getpublicandprivatekey (char *, char *);
 extern int getsecretkey (char *, char *, char *);
 __END_DECLS

>Release-Note:
>Audit-Trail:
>Unformatted: