Daemon News Ezine BSD News BSD Mall BSD Support Forum BSD Advocacy BSD Updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

yppush_main.c yppush_exit() recursion prevention

I intend to commit the following to HEAD in the forthcoming days,
unless there is an objection to this change.

When exitting upon an abnormal signal, yppush_exit() should not
attempt to clear its pending jobs list, as this could trigger another
signal, and cause an infinite recursion. What yppush_exit() tests
in order to determine whether to flush pending jobs is the
yppush_joblist chained list, so this is what needs to be cleared
in that case (not the yppush_jobs counter).

Index: yppush_main.c
RCS file: /home/ncvs/src/usr.sbin/yppush/yppush_main.c,v
retrieving revision 1.19
diff -u -r1.19 yppush_main.c
--- yppush_main.c	17 Oct 2004 19:33:33 -0000	1.19
+++ yppush_main.c	24 Dec 2004 15:38:59 -0000
@@ -208,7 +208,7 @@
 handler(int sig)
 	if (sig == SIGTERM || sig == SIGINT || sig == SIGABRT) {
-		yppush_jobs = 0;
+		yppush_joblist = NULL;

Attachment: pgp7f2MLBWDgX.pgp
Description: PGP signature